Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add requirement about Taints to the deployment guide #183

Merged
merged 1 commit into from
Jul 14, 2022
Merged

Add requirement about Taints to the deployment guide #183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/ManualDeploymentGuideScalarDBServerOnAKS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ Install the following tools on the bastion for controlling the AKS cluster:

* You must have an AKS cluster with Kubernetes version **1.19** or higher for Scalar DB deployment.
* You must create a new `user node pool` with the name `scalardbpool` for Scalar DB deployment.
* You must add Taints `kubernetes.io/app=scalardbpool:NoSchedule` to each worker node.
* You must create a Kubernetes cluster with `service principal` as the Authentication method.
* You must create a Kubernetes cluster with `Azure CNI`.

Expand Down
2 changes: 2 additions & 0 deletions docs/ManualDeploymentGuideScalarDLOnAWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,8 @@ Install the following tools on your bastion for controlling the EKS cluster:
* You must create a Kubernetes cluster with version 1.19 or higher for Scalar DL deployment.
* You must create a node group with the label, key as `agentpool` and value as `scalardlpool` for Scalar DL deployment.
* You must add a rule in the EKS security group to **enable HTTPS access (Port 443)** to the private EKS cluster from the bastion server.
* You must add Taints `kubernetes.io/app=scalardlpool:NoSchedule` to each worker node.
Copy link
Contributor

@scalar-boney scalar-boney Jul 14, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual deployment of Scalar DL worked fine for me without taint.
I did not face any issues related to this.
Let me check more about it.
Sorry for the delay.

* You need to add the Taints using the `kubectl taint node` command after you created the cluster since EKS does not support adding Taints with key `kubernetes.io/app` to the node group.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a limitation of EKS.
aws/containers-roadmap#1451


### Recommendations

Expand Down
1 change: 1 addition & 0 deletions docs/ManualDeploymentGuideScalarDLOnAzure.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ Install the following tools on the bastion for controlling the AKS cluster:

* You must have an AKS cluster with Kubernetes version **1.19** or higher for Scalar DL deployment.
* You must create a new `user node pool` with the name `scalardlpool` for Scalar DL deployment.
* You must add Taints `kubernetes.io/app=scalardlpool:NoSchedule` to each worker node.
* You must create a Kubernetes cluster with `service principal` as the Authentication method.
* You must create a Kubernetes cluster with `Azure CNI`.
* You must select the subnet other than `k8s_ingress` subnet for creating the AKS cluster.
Expand Down