Scalameta: upgrade to v4.9.4 #3986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tgodzik any ideas on what to do about this jline error? i don't know where this library is coming from. also see jline/jline3#954 and sbt/sbt#7500. should we downgrade our version of sbt, or sbt-native-packager, or something else? |
I think we might want to downgrade sbt, though curious why this hasn't happened in a previous PR |
|
ah, must be something picked up by scalameta, then 😞 |
Replace the general scala3 dialect check (on significantIndentation) to more specific (quiet syntax and end marker, respectively).
looks like it was the new version of scala (2.13.14). i switched back to 2.13.13, and no error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.