Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FormatWriter: don't insert braces in annotation #3913

Merged
merged 2 commits into from
Apr 9, 2024

Conversation

kitbellew
Copy link
Collaborator

Fixes #3912.

@kitbellew kitbellew requested a review from tgodzik April 9, 2024 09:32
@kitbellew
Copy link
Collaborator Author

@tgodzik apparently, scala2 is ok but 3 is not; we don't have a dialect flag for this, and i don't think it is important enough to add a config parameter to control this, so I'm simply disabling it. wdyt?

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@kitbellew kitbellew merged commit 3b3ec57 into scalameta:master Apr 9, 2024
9 checks passed
@kitbellew kitbellew deleted the 3912 branch April 9, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Annotation argument is not a constant
2 participants