ScalafmtConfig: require version in a config file
#2843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitbellew
changed the title
version a required fieldversion in a config file
kitbellew
force-pushed
the
mver
branch
2 times, most recently
from
2f907dc to
710ed41
Compare
tgodzik
approved these changes
Nov 2, 2021
| * The version of scalafmt to use for this project. Currently not used, the | ||
| * plan is to use this field for the IntelliJ+sbt integrations. | ||
| * The version of scalafmt to use for this project. Must match the current | ||
| * binary version. |
There was a problem hiding this comment.
What do you mean by binary version? Scala binary version?
There was a problem hiding this comment.
how should i rephrase it? i meant the version of scalafmt that is running (aka, no dynamic resolution at this stage).
There was a problem hiding this comment.
just maybe Must match the current version?
| @@ -48,4 +48,8 @@ object ScalafmtDynamicError { | |||
|
|
|||
| case class UnknownError(cause: Throwable) | |||
| extends ScalafmtDynamicError("unknown error", cause) | |||
|
|
|||
| object ConfigVersionRequired | |||
| extends Error("Version will be required, can't replace with default") | |||
There was a problem hiding this comment.
Suggested change
| extends Error("Version will be required, can't replace with default") | |
| extends Error("Version is required, it can't be replaced with default") |
?
There was a problem hiding this comment.
there's a nuance here. the configuration file might contain a version so the user could find this error message misleading.
what i'd like to say is, we can't use withRespectVersion or withDefaultVersion (whether or not version is present in the configuration file) because they would allow a version to be missing.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.