Fix a problem where parens are removed after a yield #2118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it's a problem when there is no space between the yield and the parens because it leaves the code in a broken state (won't compile) Fixes scalameta#2117
kitbellew
reviewed
Jul 25, 2020
| object a { | ||
| val x = for { | ||
| a <- b | ||
| } yield(a) |
There was a problem hiding this comment.
is this specific to yield? what about:
a match {
case a if(a) => a
}
There was a problem hiding this comment.
I'm testing it as we speak, I'll open another MR if it also fails there
There was a problem hiding this comment.
Ahh I just saw you PR, great. I was not sure if extra spaces would be removed later on
There was a problem hiding this comment.
i already fixed it, see linked pr.
There was a problem hiding this comment.
and thank you for not only reporting a problem but also fixing it. doesn't happen too often :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it's a problem when there is no space between the yield and the
parens because it leaves the code in a broken state (won't compile)
Fixes #2117