Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use Boolean in check tasks, they throw #165

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

kitbellew
Copy link
Contributor

No description provided.

@@ -246,14 +246,13 @@ object ScalafmtPlugin extends AutoPlugin {
)
}

private def trueOrBoom(analysis: ScalafmtAnalysis): Boolean = {
private def trueOrBoom(analysis: ScalafmtAnalysis): Unit = {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
private def trueOrBoom(analysis: ScalafmtAnalysis): Unit = {
private def throwOnFailures(analysis: ScalafmtAnalysis): Unit = {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added in #168. merging this one for now.

@kitbellew kitbellew merged commit 0fe0f5b into scalameta:master Nov 15, 2021
@kitbellew kitbellew deleted the 165 branch November 15, 2021 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants