ScalafmtSessionFactory usage #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitbellew
reviewed
May 11, 2020
| import java.nio.file.Path | ||
| import org.scalafmt.interfaces.{Scalafmt, ScalafmtSession} | ||
|
|
||
| class PluginInstanceSession(config: Path, instance: Scalafmt) |
There was a problem hiding this comment.
- should it be package-private?
- perhaps rename to something like
LegacyScalafmtSessionorCompatibilityScalafmtSessionorEmulatedScalafmtSession?
| globalInstance | ||
| .withReporter(reporter) | ||
| .withMavenRepositories(repositories: _*) | ||
| .withRespectProjectFilters(true) match { |
There was a problem hiding this comment.
this line wasn't there before. probably a good change. could it potentially cause some complaints?
There was a problem hiding this comment.
Looks like it's on-by-default. Just explicitly declare this setting because sbt plugin hasn't other inputs than filters specified in config.
kitbellew
approved these changes
May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #96