Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Scala Native multithreading #861

Merged
merged 3 commits into from
Dec 17, 2024

Conversation

WojciechMazur
Copy link
Contributor

Since Scala Native 0.5.0 we have access to multithreading support, it's enabled by default if we detect usage of threading in the compiled code. This change does acknowledge multihreading support in PlatformCompat for Native (mostly copy-paste based on JVM implementation with minor changes)

Additional changes required to unsupress Issue285FrameworkSuite:

  • Don't print stacktrace of the uncought exception - it's not reported on the JVM. Make the outputs of JVM and JS/Native compliant
  • Handle optional possible extra space before <elapsed time> pattern - it is sometimes produced by the JVM
  • Print elapased time milliseconds using 3 digits instead of 2 (to follow JVM semantics)

… print stack trace of exceptions and acknoledge optional space before elapsed time on the JVM
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@tgodzik tgodzik merged commit 19fe2f6 into scalameta:main Dec 17, 2024
9 checks passed
@WojciechMazur WojciechMazur deleted the scala-native/multithreading branch December 17, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants