Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add buffered logging option #397

Merged
merged 3 commits into from
Aug 9, 2021
Merged

Conversation

jenshalm
Copy link
Contributor

@jenshalm jenshalm commented Aug 6, 2021

This is the original commit which adds the new +b flag, plus a small bugfix and documentation.

IMHO the section "Run tests in parallel" should be on the Getting Started page, which focuses on running tests, and not on the page which focuses on writing tests. If you agree, I'm happy to make that change, too.

This PR does not contain any possible refactoring/simplification we discussed, as that would be better done with a separate PR.

@jenshalm jenshalm changed the title add buffered logging option Add buffered logging option Aug 6, 2021
Copy link
Member

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Feel free to follow up with a separate PR to enable this option by default. I think it makes sense to turn this on by default given that sbt uses parallel execution by default.

@olafurpg olafurpg merged commit 28d696b into scalameta:main Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants