Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Conf.Obj.getOption[T](field: String) #31

Merged
merged 2 commits into from
Dec 13, 2017
Merged

Add Conf.Obj.getOption[T](field: String) #31

merged 2 commits into from
Dec 13, 2017

Conversation

MasseGuillaume
Copy link
Contributor

No description provided.

olafurpg
olafurpg requested changes Dec 12, 2017
View reviewed changes
metaconfig-core/shared/src/test/scala/metaconfig/ConfOptionTest.scala Outdated
import org.scalameta.logger
import org.scalatest.FunSuite

object CustomMessage {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we minimize this test?

@MasseGuillaume MasseGuillaume mentioned this pull request Dec 12, 2017
Merged
olafurpg
olafurpg approved these changes Dec 13, 2017
View reviewed changes
Copy link
Member

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@olafurpg olafurpg merged commit 2aa936f into scalameta:master Dec 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olafurpg olafurpg olafurpg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MasseGuillaume @olafurpg