Add support for null #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While implementing DisableSyntax.keywords in scalafix I came across the following bug: ``` [info] java.lang.IllegalArgumentException: Unexpected config value ConfigNull(null) with unwrapped value null [info] at metaconfig.typesafeconfig.TypesafeConfig2Class$.loop$1(TypesafeConfig2Class.scala:42) [info] at metaconfig.typesafeconfig.TypesafeConfig2Class$.$anonfun$gimmeSafeConf$2(TypesafeConfig2Class.scala:32) ``` In TypesafeConfig indentifier without quotes are lifted two string automatically. For example, it's possible to write both: ``` keywords = [ override ] ``` ``` keywords = [ "override" ] ``` However if we write ``` keywords = [ null ] ``` we get the error above
MasseGuillaume
force-pushed
the
handle-null
branch
from
c127a7d to
9d71468
Compare
MasseGuillaume
referenced
this pull request
in MasseGuillaume/scalafix
Nov 15, 2017
requires https://github.com/olafurpg/metaconfig/pull/29 to handle null in metaconfig
olafurpg
approved these changes
Nov 15, 2017
| </developer> | ||
| </developers> | ||
| developers += | ||
| Developer( |
There was a problem hiding this comment.
Why this change? It's not bad but it kind of distracts from the actual PR.
MasseGuillaume
referenced
this pull request
in MasseGuillaume/scalafix
Nov 16, 2017
requires https://github.com/olafurpg/metaconfig/pull/29 to handle null in metaconfig
MasseGuillaume
referenced
this pull request
in MasseGuillaume/scalafix
Nov 16, 2017
requires https://github.com/olafurpg/metaconfig/pull/29 to handle null in metaconfig
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While implementing DisableSyntax.keywords in scalafix I came across the following bug:
In TypesafeConfig indentifier without quotes are lifted two string automatically. For example, it's
possible to write both:
However if we write
we get the error above