Levenshtein: change how ratio is computed #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitbellew
force-pushed
the
78
branch
2 times, most recently
from
490d8e6 to
934a68b
Compare
Previously, we selected by the minimum Levenshtein distance, then used additional logic to compute a ratio (which may not monotonically track the distance values). Instead, sort by the final ratio. As the tests can now attest, the current computation of ratio might be too optimistic, as suggestions are not as tight.
Don't subtract the length difference from distance, as that leads to low numbers (frequently, zero) on pairs which are quite dissimilar. Instead, divide by the length of the longer of the two.
olafurpg
approved these changes
May 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't subtract the length difference from distance, as that leads to low numbers (frequently, zero) on pairs which are quite dissimilar. Instead, divide by the length of the longer of the two.
Fixes #78.