-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update versions to support Scala Native #104
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 thank you!
Thanks @olafurpg, we are waiting on the Scala Native support for paiges typelevel/paiges#338. Once everything is working in CI then we should be good to go. |
Paiges 0.4.1 is out |
@ekrich should I take a look at the PR and update paiges? |
I was working on update I did see that paiges was updated. |
@tgodzik Between |
@ekrich the other PR is merged and CI is fixed. We should be good to rebase this one 🎉 |
Sure, I will go ahead and rebase and then make the other changes. Note that @olafurpg said it was ok to drop 2.11 because paiges is 2.12+. |
This works without tests but I cannot add them until the following project gets Native support. I can do this but it will take a few days - hopefully. Added ticket: alexarchambault/scalacheck-shapeless#205 |
It's only |
I guess it is pretty much up to you. The tests being cross project would be nice. We could add a ticket to the scalacheck-shapeless and do that longer term on another PR - I don't know how much it is used so I don't know if it could be removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can follow up with a PR to separate the test tomorrow. I think we should be ok to merge and release? What do you think @olafurpg ? I fixed the release and it should work alright.
LGTM ship it! |
No description provided.