Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Scala 2.11 support and update pprint/fnase/metaconfig #603

Merged
merged 1 commit into from
Jan 21, 2022
Merged

Drop Scala 2.11 support and update pprint/fnase/metaconfig #603

merged 1 commit into from
Jan 21, 2022

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Jan 10, 2022 •
edited
Loading

Fixes #602

It seem there were a lot of changes in pprint:
com-lihaoyi/PPrint@7fead8d#diff-492a668d78a78a50945e22826d563419a9c827b6164bca4bfedb3a7c4f66d551

It seems we need t first bump this in metaconfig. it's updated, but metaconfig no longer publishes for 2.11, so we need to drop it in mdoc also, which I think is not an issue, since people can stay with older versions for now. Opinions?

@tgodzik
Copy link
Contributor Author

tgodzik commented Jan 10, 2022

scalameta/metaconfig#151 is required to make this work.

@tgodzik tgodzik mentioned this pull request Jan 10, 2022
Merged
@tgodzik tgodzik force-pushed the bump-fansi-pprint branch 5 times, most recently from 77e7717 to 5208716 Compare January 19, 2022 17:17
@tgodzik tgodzik changed the title Bump pprint, fansi and fs2. Also, refactor them to be detected by steward Drop Scala 2.11 support and update pprint/fnase/metaconfig Jan 20, 2022
@tgodzik tgodzik marked this pull request as ready for review January 20, 2022 09:40
@tgodzik tgodzik requested review from keynmol and olafurpg January 20, 2022 09:40
@olafurpg
Copy link
Member

Fine by me👍

keynmol
keynmol approved these changes Jan 21, 2022
View reviewed changes
Copy link
Collaborator

@keynmol keynmol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has a bulk of changes that put me off metaconfig upgrade in https://github.com/scalameta/mdoc/pull/563/files
I should rebase my PR at some point.

@tgodzik tgodzik merged commit fea72d3 into scalameta:main Jan 21, 2022
@tgodzik tgodzik deleted the bump-fansi-pprint branch January 21, 2022 14:55
@mrdziuban
Copy link
Contributor

I just ran into a NoSuchMethodError when attempting to upgrade PPrint in my codebase and found this while searching for solutions. Would it be possible to release a new version of mdoc with these dependency updates included?

@tgodzik
Copy link
Contributor Author

tgodzik commented Jan 27, 2022

I just ran into a NoSuchMethodError when attempting to upgrade PPrint in my codebase and found this while searching for solutions. Would it be possible to release a new version of mdoc with these dependency updates included?

I am working on that, but the pprint icompatibility is proving to cause a whole lot more problems than expected 😓

@tgodzik
Copy link
Contributor Author

tgodzik commented Jan 28, 2022

@mrdziuban This should work with the latest release, do try it out 🙏

@mrdziuban
Copy link
Contributor

Confirmed, mdoc 2.3.0 and pprint 0.7.1 play nicely together in my codebase -- thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keynmol keynmol keynmol approved these changes

@olafurpg olafurpg Awaiting requested review from olafurpg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update pprint version to 0.7.1?
4 participants
@tgodzik @olafurpg @mrdziuban @keynmol