Update metaconfig-typesafe-config to 0.9.16

[scala-steward]

Updates com.geirsson:metaconfig-typesafe-config from 0.9.15 to 0.9.16.
GitHub Release Notes - Version Diff

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

Files still referring to the old version number

The following files still refer to the old version number (0.9.15).
You might want to review and update them manually.

CONTRIBUTING.md

Ignore future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "com.geirsson", artifactId = "metaconfig-typesafe-config" } ]

labels: library-update, early-semver-minor, semver-spec-patch, old-version-remains, commit-count:1

[bjaglin]

[error] /home/runner/work/scalafix/scalafix/scalafix-rules/src/main/scala/scalafix/internal/rule/DisableSyntaxConfig.scala:112:12: value literal is not a member of object pprint.TPrint
[error]     TPrint.literal("List[Regex]")

Caused by https://github.com/com-lihaoyi/PPrint/pull/72/files#diff-492a668d78a78a50945e22826d563419a9c827b6164bca4bfedb3a7c4f66d551L17

It looks like c66f24d has no effect since https://github.com/scalacenter/scalafix/pull/907/files#diff-fa445c2f97a1bfb229caa4cd2fdc97cb9c243ddac155698a132bcbdb22970910R91

[bjaglin]

[error] /home/runner/work/scalafix/scalafix/scalafix-cli/src/main/scala/scalafix/internal/v1/Args.scala:511:12: value make is not a member of object pprint.TPrint
[error]     TPrint.make[AbsolutePath](_ => "<path>")
[error]            ^
[error] /home/runner/work/scalafix/scalafix/scalafix-cli/src/main/scala/scalafix/internal/v1/Args.scala:513:12: value make is not a member of object pprint.TPrint
[error]     TPrint.make[PathMatcher](_ => "<glob>")
[error]            ^
[error] /home/runner/work/scalafix/scalafix/scalafix-cli/src/main/scala/scalafix/internal/v1/Args.scala:515:12: value make is not a member of object pprint.TPrint
[error]     TPrint.make[Conf](implicit cfg => TPrint.implicitly[ScalafixConfig].render)
[error]            ^
[error] /home/runner/work/scalafix/scalafix/scalafix-cli/src/main/scala/scalafix/internal/v1/Args.scala:520:12: value make is not a member of object pprint.TPrint
[error]     TPrint.make { implicit cfg =>
[error]            ^
[error] /home/runner/work/scalafix/scalafix/scalafix-cli/src/main/scala/scalafix/internal/v1/Args.scala:526:12: value make is not a member of object pprint.TPrint
[error]     TPrint.make { implicit cfg =>
[error]            ^
[error] 5 errors found

Caused by https://github.com/com-lihaoyi/PPrint/pull/72/files#diff-492a668d78a78a50945e22826d563419a9c827b6164bca4bfedb3a7c4f66d551L23

[tgodzik]

@bjaglin it should be possible to work around it similar to how I did it in mdoc: https://github.com/scalameta/mdoc/pull/603/files#diff-a8b31f6574d70bc4d9f927ba67d848b1161bceb085b9248a50f50338c70bfac7R304

[bjaglin]

@tgodzik thanks for the pointer! It turned out to be a bit more convoluted because of

scalafix/project/Dependencies.scala

Line 26 in de374ad

val metaconfigFor211V = "0.9.10" // metaconfig stops publishing for scala 2.11

but it looks like I found something that does not require specific scala-2.11 source files to compile.

However, there seems to be a bigger problem: the breaking changes in TPrint companion object from com-lihaoyi/PPrint#72 make it impossible to classload community rules compiled against the old one

[info] - fetch & load instance for Scala version 2.12 with external dependencies *** FAILED *** (839 milliseconds)
[info]   java.util.ServiceConfigurationError: scalafix.v1.Rule: Provider fix.SortImports could not be instantiated
[info]   at java.util.ServiceLoader.fail(ServiceLoader.java:232)
[info]   at java.util.ServiceLoader.access$100(ServiceLoader.java:185)
[info]   at java.util.ServiceLoader$LazyIterator.nextService(ServiceLoader.java:384)
[info]   at java.util.ServiceLoader$LazyIterator.next(ServiceLoader.java:404)
[info]   at java.util.ServiceLoader$1.next(ServiceLoader.java:480)
[info]   at scala.collection.convert.Wrappers$JIteratorWrapper.next(Wrappers.scala:46)
[info]   at scala.collection.Iterator.foreach(Iterator.scala:943)
[info]   at scala.collection.Iterator.foreach$(Iterator.scala:943)
[info]   at scala.collection.AbstractIterator.foreach(Iterator.scala:1431)
[info]   at scala.collection.generic.Growable.$plus$plus$eq(Growable.scala:62)
[info]   ...
[info]   Cause: java.lang.NoSuchMethodError: pprint.TPrint$.lambda(Lscala/Function1;)Lpprint/TPrint;
[info]   at fix.SortImportsConfig$.<init>(SortImports.scala:19)
[info]   at fix.SortImportsConfig$.<clinit>(SortImports.scala)
[info]   at fix.SortImports.<init>(SortImports.scala:30)
[info]   at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
[info]   at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
[info]   at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
[info]   at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
[info]   at java.lang.Class.newInstance(Class.java:442)
[info]   at java.util.ServiceLoader$LazyIterator.nextService(ServiceLoader.java:380)
[info]   at java.util.ServiceLoader$LazyIterator.next(ServiceLoader.java:404)

I'll follow-up in scalameta/metaconfig#151

[tgodzik]

Do we need to publish scalafix for 2.11 though? Isn't metaconfig only needed for CLI/sbt ?

[bjaglin]

Scalafix must be published in 2.11 for ExplicitResultTypes to work against 2.11 sources. This is something we can challenge though.

metaconfig is included in community rules projects via scalafix-core and is documented

$ cs resolve -t com.github.liancheng::organize-imports:0.6.0
└─ com.github.liancheng:organize-imports_2.13:0.6.0
   ├─ ch.epfl.scala:scalafix-core_2.13:0.9.31
   │  ├─ com.geirsson:metaconfig-typesafe-config_2.13:0.9.14
   │  │  ├─ com.geirsson:metaconfig-core_2.13:0.9.14

[bjaglin]

Following up in #1530 seems that steward gets confused on which artifacts gets bumped) which should unblock the situation as discussed in scalameta/metaconfig#154 (comment).