Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework migrate-scalacOptions, rename commands and update readme #426

Merged
merged 3 commits into from
Aug 30, 2023
Merged

Rework migrate-scalacOptions, rename commands and update readme #426

merged 3 commits into from
Aug 30, 2023

Conversation

adpi2
Copy link
Member

@adpi2 adpi2 commented Aug 29, 2023

Output of migrateScalacOptions

Before the PR:
image

After the PR:
image

Notice that I removed all the plugin options because they are either already handled by the migrateDependencies command or they are managed by sbt-plugins (scalajs, scoverage, semanticdb, etc)

New names of the commands

migrate-libs -> migrateDependencies
migrate-scalacOptions -> migrateScalacOptions
migrate-syntax -> migrateSyntax
migrate -> migrateTypes

@adpi2 adpi2 requested a review from sjrd August 29, 2023 09:57
sjrd
sjrd requested changes Aug 30, 2023
View reviewed changes
plugin/src/main/scala/migrate/CommandStrings.scala Outdated Show resolved Hide resolved
plugin/src/main/scala/migrate/CommandStrings.scala Outdated Show resolved Hide resolved
plugin/src/main/scala/migrate/ScalaMigratePlugin.scala Outdated Show resolved Hide resolved
migrate/src/main/scala/migrate/ScalacOptionsMigration.scala Outdated Show resolved Hide resolved
plugin/src/main/scala/migrate/ScalacOptionsMigration.scala Outdated Show resolved Hide resolved
@adpi2 adpi2 force-pushed the rework-migrate-scalacoptions branch from c59a25a to b12d41c Compare August 30, 2023 08:47
@adpi2 adpi2 force-pushed the rework-migrate-scalacoptions branch from b12d41c to 0b934fd Compare August 30, 2023 08:54
@adpi2 adpi2 force-pushed the rework-migrate-scalacoptions branch from 0b934fd to c614e20 Compare August 30, 2023 09:04
@adpi2 adpi2 merged commit ab3c1f0 into scalacenter:main Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjrd sjrd sjrd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adpi2 @sjrd