Add patches only to files having error in scala 3 #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting idea! Also if there is some compiler errors you can compute the patches only in the erroneous files and not the other ones. |
|
I do like this idea. |
mlachkar
changed the title
adpi2
approved these changes
Mar 9, 2021
|
|
||
| public class QuietReporter extends Reporter { | ||
| public void doReport(Diagnostic d, Context ctx) {} | ||
| HashSet<String> filesWithErrors = new HashSet<String>(); |
project/project/metals.sbt
Outdated
| // This file makes sure that the JDI tools are in the sbt classpath. | ||
| // JDI tools are used by the debug adapter server. | ||
|
|
||
| addSbtPlugin("org.scala-debugger" % "sbt-jdi-tools" % "1.1.1") |
There was a problem hiding this comment.
This file should be added to .gitignore
Comment on lines
+41
to
+46
| initialFileToMigrate <- buildMigrationFiles(filesWithErr) | ||
| _ <- compileInScala3( | ||
| initialFileToMigrate, | ||
| filesWithoutErrors ++ javaFiles ++ managedSources, | ||
| compiler | ||
| ) |
There was a problem hiding this comment.
This should fix the compilation errors in the filesWithErr but there may be cases where the compiler then find errors in others files, in which case we can loop to add the patches of the new filesWithErr until there is no more error.
Can be done in a V2 after we have found a case in which it happens.
There was a problem hiding this comment.
Good idea. I have to open an issue to get track of this.
To avoid computing unecessary patches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid computing unecessary patches
Still need to improve logging for this commit.