Ensure multi-module SBT plugins respect excludedModules setting
#199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrf
reviewed
Apr 11, 2024
sbt-version-policy/src/main/scala/sbtversionpolicy/internal/DependencyCheck.scala
Outdated
Show resolved
Hide resolved
…place as other types of modules and add a specific test for that
huajiang-tubi
pushed a commit
to adRise/sbt-version-policy
that referenced
this pull request
Jun 25, 2024
…alacenter#199) * Ensure multi-module SBT plugins respect `excludedModules` setting Co-authored-by: Julien Richard-Foy <julien@richard-foy.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On alejandrohdezma/sbt-github#516 I noticed that
sbt-version-policywasn't respecting theversionPolicyIgnoredInternalDependencyVersionssetting on multi-module SBT plugins.This was due to a mismatch on the information under
report.modules&excludedModulesin theDependencyCheck.modulesOfmethod. On SBT plugin buildsreport.modulescontains modules without the scala version suffix, whileexcludedModulescontains them with the suffix.The fix introduced in this PR checks for the presence of
sbtVersionandscalaVersion"extra" attributes in theModuleIDand creates the appropriate cross-version string name in that case.