Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Exception on parallel export #33

Merged
merged 1 commit into from
May 22, 2023

Conversation

Arthurm1
Copy link
Contributor

As far as I can tell Gradle uses non-public methods to ensure lazy task discovery is complete before iterating through them. As these methods aren't accessible to the plugin, I've just synchronized around access to tasks. Doesn't seem to slow things down.

In the tests - I've made it clearer which version of Gradle can support which version of Java and so which tests are skipped for each version. The Android tests still fail - something I'll have to look into at one point.

Fixes #32

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tgodzik tgodzik merged commit ac702a9 into scalacenter:main May 22, 2023
@jvican
Copy link
Contributor

jvican commented May 22, 2023

Great work @Arthurm1! ❤️ Thank you 😄

@Arthurm1 Arthurm1 deleted the parallel_export branch June 9, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected ConcurrentModificationException
3 participants