bugfix: Use proper rt.jar if it exists #2450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we would automatically generate our own rt.jar from the Bloop's JDK, however this would put all the current JDK classes into that jar, which means some things might compile while they should not. This limitation is present both in Mill and sbt. We would only fail on added methods. Now, we try to locate rt.jar if javaHome is set, so we can use it explicitely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would automatically generate our own rt.jar from the Bloop's JDK, however this would put all the current JDK classes into that jar, which means some things might compile while they should not. This limitation is present both in Mill and sbt. We would only fail on added methods.
Now, we try to locate rt.jar if javaHome is set, so we can use it explicitely.