Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement javacOptions endpoint #1397

Merged
merged 2 commits into from
Mar 11, 2021

Conversation

tpasternak
Copy link

No description provided.

@Arthurm1
Copy link
Contributor

Hi @tpasternak

I'm glad you're doing this. Is the idea to support Java only build targets? And then is the plan for Intellij to support this or are you aiming for a different client? Also - what is the status?

@Arthurm1
Copy link
Contributor

Hi @tpasternak

Could you rebase this and convert from "Draft"? I tested against a Javac client and it looks complete.

@tgodzik tgodzik force-pushed the scalac-options-endpoint branch from d97fd7c to 65abf1b Compare March 11, 2021 07:45
@tgodzik tgodzik marked this pull request as ready for review March 11, 2021 07:45
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tgodzik tgodzik merged commit 10dc726 into scalacenter:master Mar 11, 2021
adpi2 added a commit to adpi2/scala-cli that referenced this pull request Jul 26, 2021
To get the buildTarget/javacOptions endpoint:
scalacenter/bloop#1397
adpi2 added a commit to adpi2/scala-cli that referenced this pull request Jul 26, 2021
To get the buildTarget/javacOptions endpoint:
scalacenter/bloop#1397
adpi2 added a commit to adpi2/scala-cli that referenced this pull request Jul 26, 2021
To get the buildTarget/javacOptions endpoint:
scalacenter/bloop#1397
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants