Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Zarr3 default and purge deprecations #1242

Merged
merged 92 commits into from
Mar 3, 2025
Merged

Make Zarr3 default and purge deprecations #1242

merged 92 commits into from
Mar 3, 2025

Conversation

normanrz
Copy link
Member

@normanrz normanrz commented Jan 27, 2025 •
edited
Loading

Description:

  • Makes Zarr3 the default data format
  • Removes deprecated functions, properties, arguments
  • Changes the writing behavior to include a allow_resize and allow_unaligned argument to make it more robust against accidental concurrency issues
  • MagViews are compressed by default

Issues:

Todos:

  • List all deprecations in the changelog
  • Add tests for new allow_resize behavior
  • Add allow_unaligned arg
  • Fix from_images for unexpected bboxes

Make sure to delete unnecessary points or to check all before merging:

  • Updated Changelog
  • Updated Documentation
  • Added / Updated Tests
  • Updated examples

@normanrz normanrz marked this pull request as draft January 27, 2025 21:40
philippotto
philippotto reviewed Feb 7, 2025
View reviewed changes
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great stuff 👍 I especially like the removal of all the deprecations.

However, I think I'm not yet fully understanding when allow_resize can be specified and when not. see my one comment for that.

@normanrz
Copy link
Member Author

@markbader This PR is now ready for your review.

@fm3 fm3 changed the title Make Zarr3 default and deprecations Make Zarr3 default and purge deprecations Feb 27, 2025
markbader
markbader approved these changes Mar 3, 2025
View reviewed changes
Copy link
Contributor

@markbader markbader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for cleaning up all the deprecated code and the great overview of changes in the changelog!

@normanrz normanrz changed the base branch from master to major-version-2.0 March 3, 2025 13:10
Base automatically changed from major-version-2.0 to master March 3, 2025 13:31
@normanrz normanrz enabled auto-merge (squash) March 3, 2025 13:33
@normanrz normanrz merged commit eb6810a into master Mar 3, 2025
41 checks passed
@normanrz normanrz deleted the zarr3-default branch March 3, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippotto philippotto philippotto left review comments

@markbader markbader markbader approved these changes

Assignees

@normanrz normanrz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Harden concurrency assertions for Zarr writing
3 participants
@normanrz @philippotto @markbader