Scala.js: Various JS interop fixes #9767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottybot
reviewed
Sep 10, 2020
There was a problem hiding this comment.
Hello, and thank you for opening this PR! 🎉
All contributors have signed the CLA, thank you! ❤️
Commit Messages
We want to keep history, but for that to actually be useful we have
some rules on how to format our commit messages (relevant xkcd).
Please stick to these guidelines for commit messages:
- Separate subject from body with a blank line
- When fixing an issue, start your commit message with
Fix #<ISSUE-NBR>:- Limit the subject line to 72 characters
- Capitalize the subject line
- Do not end the subject line with a period
- Use the imperative mood in the subject line ("Add" instead of "Added")
- Wrap the body at 80 characters
- Use the body to explain what and why vs. how
adapted from https://chris.beams.io/posts/git-commit
Have an awesome day! ☀️
sjrd
force-pushed
the
sjs-various-js-interop-fixes
branch
6 times, most recently
from
1fb50f4
to
53be258
Compare
smarter
reviewed
Sep 14, 2020
… objects. This restores parity with the run-time semantics of Scala 2. When accessing an inner static class or object, we avoid loading the enclosing objects as values. The discrepancy in run-time semantics was introduced as a by-product of scala#1445 The change in `t4859.check` restores it to its previous state, before that PR.
This is a forward port of the back-end changes in the upstream commit scala-js/scala-js@a1a27f2
…ase. This is basically a forward port of the changes in the upstream commit scala-js/scala-js@b2634ea
sjrd
force-pushed
the
sjs-various-js-interop-fixes
branch
from
53be258
to
9584666
Compare
nicolasstucki
approved these changes
Sep 17, 2020
This was referenced Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #9725.