adding GenBCode to dotc #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. I'll merge it into the backend branch. Are you working on the dotc backend currently? Just so that we don't work on the same thing. |
|
@lrytz The progress I've made on "GenBCode in dotc" is this PR. Before making further progress I have questions about the dotc-way to types and symbols. It would be great if you had time to discuss that. |
I'll be at EPFL tomorrow. Should we meet around 13:30? Maybe @odersky can join to answer the questions, I'll take notes. |
|
@lrytz Let's start tomorrow by reviewing the pending TODOs, and then we can ask for help :) |
smarter
pushed a commit
that referenced
this pull request
Mar 12, 2020
doc(match-type): fix type lambda syntax
romanowski
referenced
this pull request
in romanowski/dotty
Oct 23, 2020
Added preprocessor which replaces logo in docs. Provide basic Scala logo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates into dotc the main classes making up GenBCode, including their adaptation to Context passing.
What remains to be done are method-level changes. Examples of changes I'll work on next:
ArrayValue, replacementJavaSeqLiteralLabelDefyet leave in place all infrastructure for emitting jumps (still needed for try-catch-finally and others)Other changes (hint: that can be performed in parallel) are about replacing usages of the scalac Symbol and Type APIs with their dotc counterparts.
review by @lrytz