Do not generate Return nodes for throw expressions #5082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Namely throw MatchError
nicolasstucki
force-pushed
the
small-pattern-match-optimization
branch
from
831f9eb to
f88c09b
Compare
sjrd
reviewed
Sep 5, 2018
| @@ -839,7 +839,8 @@ object PatternMatcher { | |||
| default | |||
| } | |||
| case ResultPlan(tree) => | |||
| Return(tree, ref(resultLabel)) | |||
| if (tree.symbol eq defn.throwMethod) tree // Namely MatchError | |||
There was a problem hiding this comment.
Don't you want to be more general and test something like tree.tpe <:< NothingTpe instead?
sjrd
approved these changes
Sep 5, 2018
| @@ -839,7 +839,7 @@ object PatternMatcher { | |||
| default | |||
| } | |||
| case ResultPlan(tree) => | |||
| if (tree.symbol eq defn.throwMethod) tree // Namely MatchError | |||
| if (tree.tpe <:< defn.NothingType) tree // Namely MatchError | |||
There was a problem hiding this comment.
The comment is not accurate anymore. It should say "for example MatchError". Otherwise LGTM.
odersky
added a commit
to dotty-staging/dotty
that referenced
this pull request
Jun 29, 2021
Reverting to the first version of scala#5082. Fixes scala#12976
BarkingBad
pushed a commit
to BarkingBad/dotty
that referenced
this pull request
Jul 23, 2021
Reverting to the first version of scala#5082. Fixes scala#12976
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Namely throw MatchError.