-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VSCode settings for the dotty project #2750
Changes from 10 commits
227a102
bd84d36
151d6b1
351b10c
37b18f5
1e479be
cd2dbf3
1f4fb2b
1fdb0e6
caa6186
eda5730
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
// Place your settings in this file to overwrite default and user settings. | ||
{ | ||
"editor.tabSize": 2, | ||
"editor.insertSpaces": true, | ||
|
||
"files.trimTrailingWhitespace": true, | ||
|
||
"search.exclude": { | ||
"**/*.class": true, | ||
"**/*.hasTasty": true, | ||
"**/target/**": true, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this regexp should be equivalent to just |
||
"scala2-library/{doc,docs,lib,META-INF,scripts,spec,test,tools}/*": true, // only allow scala-backend/src | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you end this regexp with |
||
"scala2-library/src/[abcefimprs]*": true, // only allow scala-backend/src/library | ||
"scala-backend/{doc,docs,lib,META-INF,scripts,spec,test,tools}/*": true, // only allow scala-backend/src | ||
"scala-backend/src/[abefilmprs]*": true, // only allow scala-backend/src/compiler | ||
"scala-backend/src/scala/reflect/*": true, | ||
"scala-backend/src/scala/tools/{ant,cmd,reflect,util}*": true, | ||
"scala-backend/src/scala/tools/nsc/*.scala": true, | ||
"scala-backend/src/scala/tools/nsc/[aijrstu]*": true // only allow scala-backend/src/scala/tools/nsc/backend | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -250,7 +250,7 @@ object Build { | |
settings(commonNonBootstrappedSettings). | ||
settings( | ||
triggeredMessage in ThisBuild := Watched.clearWhenTriggered, | ||
submoduleChecks, | ||
dottyProjectFolderChecks, | ||
|
||
addCommandAlias("run", "dotty-compiler/run") ++ | ||
addCommandAlias("legacyTests", "dotty-compiler/testOnly dotc.tests") | ||
|
@@ -1138,7 +1138,7 @@ object Build { | |
)) | ||
} | ||
|
||
lazy val submoduleChecks = onLoad in Global := (onLoad in Global).value andThen { state => | ||
lazy val dottyProjectFolderChecks = onLoad in Global := (onLoad in Global).value andThen { state => | ||
val submodules = List(new File("scala-backend"), new File("scala2-library"), new File("collection-strawman")) | ||
if (!submodules.forall(f => f.exists && f.listFiles().nonEmpty)) { | ||
sLog.value.log(Level.Error, | ||
|
@@ -1147,6 +1147,10 @@ object Build { | |
| > git submodule update --init | ||
""".stripMargin) | ||
} | ||
|
||
// If contents .vscode do not exist yet, initialize them with the contents of .vscode-template/ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would say "Copy default configuration from .vscode-template unless configuration files already exist in .vscode" |
||
sbt.IO.copyDirectory(new File(".vscode-template/"), new File(".vscode/"), overwrite = false) | ||
|
||
state | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably want to exclude **/target too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done