Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add regression test for 16463 #20269

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Add regression test for 16463 #20269

merged 2 commits into from
Apr 26, 2024

Conversation

mbovel
Copy link
Member

@mbovel mbovel commented Apr 26, 2024

Closes #16463

@mbovel mbovel self-assigned this Apr 26, 2024
@mbovel
Copy link
Member Author

mbovel commented Apr 26, 2024

Seems like the message says normalizing EmptyTuple *: EmptyTuple match on the CI but reduce type EmptyTuple *: EmptyTuple match on my machine 🤔

@mbovel
Copy link
Member Author

mbovel commented Apr 26, 2024

After discussions with @EugeneFlesselle, sounds like we should not include the check file, as the specific message depends on the stack size.

@EugeneFlesselle EugeneFlesselle self-requested a review April 26, 2024 14:18
@mbovel mbovel marked this pull request as ready for review April 26, 2024 14:18
@mbovel mbovel enabled auto-merge (squash) April 26, 2024 14:19
@mbovel mbovel merged commit 8825b07 into scala:main Apr 26, 2024
36 checks passed
EugeneFlesselle added a commit to dotty-staging/dotty that referenced this pull request May 6, 2024
@EugeneFlesselle
Drop handleRecursive from MatchType#tryNormalize
3fc5826 
There is already a `handleRecursive` in `reduced`
Having the two makes error messages undeterministic, see scala#20269
@mbovel mbovel deleted the mb/16463 branch May 8, 2024 12:48
@Kordyjan Kordyjan added this to the 3.5.0 milestone May 10, 2024
EugeneFlesselle added a commit to dotty-staging/dotty that referenced this pull request Jun 11, 2024
@EugeneFlesselle
Drop handleRecursive from MatchType#tryNormalize
dc302a0 
There is already a `handleRecursive` in `reduced`
Having the two makes error messages undeterministic, see scala#20269
EugeneFlesselle added a commit to dotty-staging/dotty that referenced this pull request Jun 28, 2024
@EugeneFlesselle
Drop handleRecursive from MatchType#tryNormalize
309b1cf 
There is already a `handleRecursive` in `reduced`
Having the two makes error messages undeterministic, see scala#20269
@EugeneFlesselle EugeneFlesselle mentioned this pull request Jul 9, 2024
Open
WojciechMazur pushed a commit that referenced this pull request Aug 27, 2024
@EugeneFlesselle @WojciechMazur
Drop handleRecursive from MatchType#tryNormalize
0b6900e 
There is already a `handleRecursive` in `reduced`
Having the two makes error messages undeterministic, see #20269

[Cherry-picked 309b1cf]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EugeneFlesselle EugeneFlesselle EugeneFlesselle approved these changes

Assignees

@mbovel mbovel

Labels
None yet
Projects
None yet
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.

Performance regression in 16463.scala
3 participants
@mbovel @EugeneFlesselle @Kordyjan