Try to type as an Assign

scala · Oct 21, 2024 · 44708ec · 44708ec
1 parent ca5f467
commit 44708ec
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 3 deletions.
diff --git a/compiler/src/dotty/tools/dotc/typer/Typer.scala b/compiler/src/dotty/tools/dotc/typer/Typer.scala
@@ -3427,9 +3427,7 @@ class Typer(@constructorOnly nestingLevel: Int = 0) extends Namer
   def checkAmbiguousNamedTuple(tree: untpd.Tuple)(using Context): Unit =
     tree.trees match
       case List(NamedArg(name, value)) =>
-        val typedName = typedIdent(untpd.Ident(name), WildcardType)
-        val sym = typedName.symbol
-        if sym.exists && (sym.is(Flags.Mutable) || sym.setter.exists) then
+        if typedAssign(untpd.Assign(untpd.Ident(name), value), WildcardType) != EmptyTree then
           report.migrationWarning(AmbiguousNamedTupleAssignment(name, value), tree.srcPos)
       case _ =>
 

diff --git a/tests/warn/21681c.check b/tests/warn/21681c.check
@@ -0,0 +1,7 @@
+-- [E203] Syntax Migration Warning: tests/warn/21681c.scala:6:2 --------------------------------------------------------
+6 |  (age = 29) // warn
+  |  ^^^^^^^^^^
+  |  Ambiguous syntax: this is interpreted as a named tuple with one element,
+  |  not as an assignment.
+  |
+  |  To assign a value, use curly braces: `{age = 29}`.
diff --git a/tests/warn/21681c.scala b/tests/warn/21681c.scala
@@ -0,0 +1,7 @@
+
+object Test:
+  def age: Int = ???
+  def age_=(x: Int): Unit = ()
+  age = 29
+  (age = 29) // warn
+