Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Mac installation instructions #3067

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Update Mac installation instructions #3067

merged 2 commits into from
Sep 4, 2024

Conversation

mbovel
Copy link
Member

@mbovel mbovel commented Sep 4, 2024

  • Remove specialized message for Apple Silicon.
  • Use the coursier brew formula.

- Remove specialized message for Apple Silicon.
- Use the `coursier` brew formula.
@hamzaremmal
Copy link
Member

I will wait for @SethTisue's approval before merging

@@ -2,5 +2,5 @@ linux-x86-64: curl -fL https://github.com/coursier/coursier/releases/latest/down
linux-arm64: curl -fL https://github.com/VirtusLab/coursier-m1/releases/latest/download/cs-aarch64-pc-linux.gz | gzip -d > cs && chmod +x cs && ./cs setup
macOS-x86-64: curl -fL https://github.com/coursier/coursier/releases/latest/download/cs-x86_64-apple-darwin.gz | gzip -d > cs && chmod +x cs && (xattr -d com.apple.quarantine cs || true) && ./cs setup
macOS-arm64: curl -fL https://github.com/VirtusLab/coursier-m1/releases/latest/download/cs-aarch64-apple-darwin.gz | gzip -d > cs && chmod +x cs && (xattr -d com.apple.quarantine cs || true) && ./cs setup
macOS-brew: brew install coursier/formulas/coursier && cs setup
macOS-brew: brew install coursier && coursier setup
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the change from cs to coursier? I've never been clear on the difference. I think I usually see cs?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because for me, brew install coursier only installs coursier. It's then coursier setup that installs other things such as cs:

➜  ~ brew install coursier
...
➜  ~ which coursier   
/usr/local/bin/coursier
➜  ~ which cs
cs not found
➜  ~ coursier setup
...
Checking if the standard Scala applications are installed
  Installed ammonite
  Installed cs
  Installed coursier
  Installed scala
  Installed scalac
  Installed scala-cli
  Installed sbt
  Installed sbtn

Copy link
Member

@bishabosha bishabosha Sep 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a difference between the homebrew-core formula and coursier's own tap - core doesn't include cs but the tap does

Copy link
Member

@bishabosha bishabosha Sep 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but the tap will only install the x86 cs, so the core formula is better - as it will resolve the Apple Silicon cs from the cs.json app descriptor

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SethTisue the difference is that coursier is a jar-based launcher rather than graalvm native image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, I mean at some level this is all deeply confusing and clear as mud, but it sounds like this is mergeable 🤷

@SethTisue SethTisue merged commit 1828c47 into main Sep 4, 2024
2 checks passed
@SethTisue SethTisue deleted the mb/apple-silicon branch September 4, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants