Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

write tabs inline in markdown #2405

Merged
merged 1 commit into from
May 26, 2022
Merged

write tabs inline in markdown #2405

merged 1 commit into from
May 26, 2022

Conversation

bishabosha
Copy link
Member

@bishabosha bishabosha commented May 25, 2022 •
edited
Loading

we can now write tabs inline in a markdown file, this makes it more simple to use, in preparation for using tabs more widely

still generate the same html as before

@bishabosha bishabosha requested a review from julienrf May 25, 2022 14:50
julienrf
julienrf approved these changes May 26, 2022
View reviewed changes
Copy link
Contributor

@julienrf julienrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Jamie. I’ve tested locally and the tabs still work on Firefox/Linux.

@julienrf julienrf assigned bishabosha and unassigned julienrf May 26, 2022
@bishabosha bishabosha merged commit c8a0eec into scala:main May 26, 2022
@bishabosha bishabosha deleted the inline-tabs branch June 9, 2022 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrf julienrf julienrf approved these changes

Assignees

@bishabosha bishabosha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bishabosha @julienrf