Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala Native 0.5.x #47

Merged
merged 7 commits into from
Jun 17, 2024
Merged

Conversation

sideeffffect
Copy link
Contributor

No description provided.

@WojciechMazur
Copy link
Contributor

Thank you for the PR, I've stepped to try to resolve the remaining issues. The tests are failing on Ubuntu (which works fine on my Apple M1 machine) when multithreading is enabled (by default). I would need to test why it happens, should have a bit more time to do it later this week.

@WojciechMazur
Copy link
Contributor

@lolgab I've figured out the reason - it was use-after-free errors. I've made a fix applied to this PR sideeffffect#2. Can you take a look at it?
The fix involved replacing manual memory management with a GC. Not sure if it's a best way to go with or would it fit the current approach

@lolgab
Copy link
Collaborator

lolgab commented Jun 17, 2024

Thank you @sideeffffect and @WojciechMazur!
Thanks to all the improvements in Scala Native 0.5 you could remove many hacks I added in the past to make this library work!

@lolgab lolgab merged commit 396a781 into scala-native:master Jun 17, 2024
1 check passed
@sideeffffect sideeffffect deleted the scala-native-0.5.x branch June 17, 2024 09:04
@sideeffffect
Copy link
Contributor Author

@lolgab could you please make a new release? 🙏

@lolgab
Copy link
Collaborator

lolgab commented Jun 19, 2024

@sideeffffect Done ✅ 0.3.0 is on Maven Central.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants