Fix cant click on iOS #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the frame must be on self not in _bannerView
|
Doesn't work for me on DFP Publisher banner. |
|
+1 fix worked for me using AdMobBanner. Would be great to get this change merged and released |
|
Awesome! Thanks a lot! |
|
@avishayil @jerson The same change needs to be applied to |
|
@jerson I pushed that fix to my own fork if you want to merge that in. See: ndbroadbent@c5e8252 |
ndbroadbent
added a commit
to ndbroadbent/react-native-admob
that referenced
this pull request
Feb 19, 2017
|
@ndbroadbent thx it worked ! 🎉 |
Improved code style
aparedes
added a commit
to aparedes/react-native-admob
that referenced
this pull request
Mar 8, 2017
Fixes RNDFPBannerView frame to allow the user to tap on a DFP Banner. This is related to sbugert#70.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the frame must be on self not in _bannerView