Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Warning: PropTypes has been moved" #182

Closed
wants to merge 1 commit into from

Conversation

fgh151
Copy link

@fgh151 fgh151 commented Sep 21, 2017

There was an warning:
Warning: PropTypes has been moved to a separate package. Accessing React.PropTypes is no longer supported and will be removed completely in React 16. Use the prop-types package on npm instead. (https://fb.me/migrating-from-react-proptypes)
I fixed it.

@koenpunt
Copy link
Collaborator

Hi @fgh151, thanks for your contribution. A version 2 of the library is currently being developed, which will make use of the prop-types library. You can follow the development here: #165.
And since adding the dependency isn't backwards compatible this is not something we're going to add to the 1.x version.

@koenpunt koenpunt closed this Sep 28, 2017
@koenpunt
Copy link
Collaborator

But if you have any input for improvement for v2, please let us know by commenting on the before mentioned PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants