Extensions for latest ScalaBuff version #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o contain scalabuff version
execute scalabuff on ALL .protos if even just a single file has changed (required for Protobuf imports)
thomasschoeftner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this pull request contains a variety of extensions for compatibility with the latest ScalaBuff version.
(1) Upgraded default ScalaBuff version to 1.3.9.
Currently, only 1.3.8 is out, but that version seems ambigous (i.e. changes were made to 1.3.8 without version bump -> pull request to create ScalaBuff 1.3.9 is pending)
(2) upgrade to Protobuf 2.5.0 (in acc. with ScalaBuff, Akka, and most other libs)
(3) changed output folder to plain source-managed (better IDE integration)
(4) changed input of protos - instead of processing individual protos, let ScalaBuff process entire folder via --proto-path param (includes between protos do not work otherwise)
cheers,
-Tom