Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying classifier for default package in deployment settings #992

Merged
merged 2 commits into from
Jun 6, 2017

Conversation

Krever
Copy link

@Krever Krever commented May 31, 2017

Hi there

This PR introduce the ability to provide an artifact classifier for default packages when calling makeDeploymentSettings.

We need this feature in our build process and I see no other workaround that to produce second artifacts with addPackage call.

Copy link
Contributor

@muuki88 muuki88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 😃
LGTM . No idea why this wasn't there in the first place.

@muuki88
Copy link
Contributor

muuki88 commented Jun 6, 2017

I restarted the travis build as it seemed to have timed out.

@muuki88 muuki88 merged commit 7704e98 into sbt:master Jun 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants