Informative failure for missing files mapped in universal #83
Conversation
|
@gmjabs Please sign the latest Typesafe Contributors License Agreement so that we can review and hopefully merge this Pull Request: |
|
Hmm, this isn't the only manifestation of using universal files.... Do you think we should move the validation somewhere else so it shows up regardless of the zip mechanisms? (e.g Otherwise looks great! THanks for the contribution. |
|
Probably should do. I could move the check to stagFiles in the plugin --- that should be common ancestor to all the actual zipping. I'll try that if you think it makes sense. |
|
Well, actually, stageFiles isn't actually a common ancestor, since you don't need to stage before zipping. I'm not quite sure where this check should be, besides in universal:package-bin. We may need to invent a new key "checkedMappings" or something that all the various downstream consumers use and we can put the check between mappings + checkedMappings.... |
|
I mis-assumed how things were working... I had trouble getting an interim check task to work with what's in there because I don't understand everything that's going on, but seems like checking mapped files exist when you're makePackageSettings-ing should cover all the cases? |
|
yeah, that's a quite nice place to hook for the message. I agree that I could do a better job with wiring here :). The flow of data doesn't actually exist on the filesystem, but in the keys. In any case, thanks much for the fix! This looks great. |
Informative failure for missing files mapped in universal
Error out with a useful message if a mapped file in unversal doesn't exist.
From #23