Expand the java home argument #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @cquiroz, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Typesafe Contributors License Agreement: |
|
Thanks for the pull request. Code LGTM. +1 for the test. You can add some docs and then this is good to merge :) |
|
Added documentation on the new option and a recipe for embedding the JVM |
|
Thanks :) Keep up the high quality for you pull request 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to #816 and it changes the bash launcher to expand variables inside the
java-homevariable. This lets you build self-contained tarballs that contain the jre and use it to launch the applicationWith this PR you can define, e.g.
-java-home ${app_home}/../jreand theapp_homevariable will be resolvedA test is included, execute with
The updated launcher has been tested with bash 3.2.7 in OSX and bash 4.1.2 in CentOS 6
If this is accepted I would provide documentation for the website too