Extract Systemloaders into AutoPlugins #785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's a good idea IMHO. |
|
What would it even mean to have multiple system loaders?
|
|
Thanks for your feedback. I will create an implementation see how everything plays out. |
muuki88
force-pushed
the
wip/systemloader-plugins
branch
from
ff9c318
to
3cd3feb
Compare
muuki88
force-pushed
the
wip/systemloader-plugins
branch
from
cf81cd2
to
1d34fad
Compare
muuki88
changed the title
|
I will merge this and release as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Systemloader Plugin - Proposal
Goal of this PR is to refactor the
JavaServerAppPackagingautoplugin and make system-loaders more flexible and configurable.The main idea is to split the systemloaders in separate AutoPlugins. Usage would look like this
This would trigger all the special server-folders and the configuration of a systemd start script.
Squeezing every customization into the
JavaServerAppPackagingdoesn't scale well codewise. The main pain point is, that things like this won't work anymoreWe probably could allow something like
when break our API and really isolate the systemloaders. However I'm not sure if this is a common need to
The solution would, again, be submodules with different configurations.
Related issues
cc: @eed3si9n @dwhjames @fiadliel @metasim @kardapoltsev