Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added CombinedCmd and removed EnvCmd #628

Merged
merged 1 commit into from
Jul 24, 2015
Merged

Added CombinedCmd and removed EnvCmd #628

merged 1 commit into from
Jul 24, 2015

Commits on Jul 24, 2015

  1. Added CombinedCmd and removed EnvCmd 

    I added CombinedCmd for ONBUILD instruction and possible future commands that will be added that will have a similar form. For readability I made it so that it uses a CmdLike object as an argument. Cmd could also be used with an extra argument but it would degrade readability. Removed ENV because it introduced an inconsistency with ADD and COPY. Made `Cmd` accept multiple arguments because this solves the ADD and ENV issue. This fix won't break the old api because a string with a space in the middle is still acceptable only less readable.
    Martijn Riemers committed Jul 24, 2015
    Configuration menu
    Copy the full SHA
    4c190b9 View commit details
    Browse the repository at this point in the history