re #577 fix for running the bash file in a path with spaces #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. I'll see if I can run the windows tests |
| @@ -235,9 +235,9 @@ run() { | |||
| fi | |||
|
|
|||
| if [ -n "$custom_mainclass" ]; then | |||
| mainclass="$custom_mainclass" | |||
| mainclass=("$custom_mainclass") | |||
There was a problem hiding this comment.
what do the round brackets achieve here?
There was a problem hiding this comment.
Needs to be an array (see also declare -a and [@] stuff)
|
@francisdb I'm checking now if the jar builds are generally broken on windows. On linux we seem to be fine, still I have a strange feeling about this on windows. #586 |
|
@muuki88 since I did not touch windows stuff, the LauncherJarPlugin generally still works on non-with-spaces folders. The bat file still needs a fix to be run on paths with spaces (which is not uncommon for windows these days) But since the linux/macos issue is fixed this can already be merged |
|
okay. will do this after the weekend |
muuki88
added a commit
that referenced
this pull request
May 27, 2015
re #577 fix for running the bash file in a path with spaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes the issue for mac/linux
have not tested or modified anything windows related