Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix SystemV init script template for rpm packaging #541

Merged
merged 2 commits into from
Apr 5, 2015
Merged

fix SystemV init script template for rpm packaging #541

merged 2 commits into from
Apr 5, 2015

Commits on Apr 4, 2015

  1. fix SystemV init script template for rpm packaging 

    Main fix is to make use of the `daemon` library function in `start`, correcting broken invocation of `runuser`.

For processes that manage their own pid file, they should define the `PIDFILE` variable (sourced either through `/etc/default/…` or `/etc/sysconfig/…`). Otherwise, if undefined, this script will capture the pid and write it to `/var/run/${{app_name}}/running.pid`.

Other minor changes:

- don’t need to call `success`/`failure` in `start` as this is already done by `daemon`
- don’t need to create `/var/run/${{app_name}}` dir as this is already done by the linux package mappings and thus the dir is created at package install time.
    @dwhjames
    dwhjames committed Apr 4, 2015
    Configuration menu
    Copy the full SHA
    45bc5db View commit details
    Browse the repository at this point in the history

  2. fix: templating for /etc/sysconfig/ path 

    $prog is undefined at this point
    @dwhjames
    dwhjames committed Apr 4, 2015
    Configuration menu
    Copy the full SHA
    0f579d6 View commit details
    Browse the repository at this point in the history