Codacy recommended cleanup. #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice. Thanks :) |
|
There is a change in logic, which broke the tests. However I'm not sure why the windows tests only run on my PRS. Can you provide a second pull request? |
|
The error if (f == null) Seq() else Seq(f) ++ allParentDirs(f.getParentFile)
// with braces
if (f == null) { Seq() } else { Seq(f) ++ allParentDirs(f.getParentFile) }
// so this would be
Option(f).map(f => f :+ allParentDirs(f.getParentFile) ) getOrElse Seq() |
|
Oh, sorry about that. Yeah, that's clearer with braces. What do you think about this? It preserves the ordering as well. Option(f).toSeq.flatMap(f => f +: allParentDirs(f.getParentFile)) |
|
I wasn't sure how to test my own change. I think I now have appveyor setup correctly so that I can test the fix myself before making the pull request this time. |
Merged
|
Oh xD This is a misconfiguration on our side. Have to check when I'm back in Germany why appveyor is no running on pull request that don't come from this repo. However thanks for testing this 👍 LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should not be a functional change. It is just some of recommended clean up from https://www.codacy.com/public/nepomukseiler/sbt-native-packager/dashboard
I was just snooping and figured, might as well fix a couple.