Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX #502 Removing JAVA_OPTS #503

Merged
merged 4 commits into from
Feb 25, 2015
Merged

FIX #502 Removing JAVA_OPTS #503

merged 4 commits into from
Feb 25, 2015

Conversation

muuki88
Copy link
Contributor

@muuki88 muuki88 commented Feb 23, 2015

No description provided.

val pr = new StringBuilder()
val logger = ProcessLogger((o: String) => pr.append(o+"\n"),(e: String) => pr.append("error < " + e+"\n"))
val cmd = Seq("cmd", "/c", script.getAbsolutePath) ++ args
val cmd = Seq("cmd", "/c", script.getAbsolutePath+" "+args)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, java doesn't seem to like the command sequence :(
Thanks for figuring this out

@muuki88
Copy link
Contributor Author

muuki88 commented Feb 25, 2015

@nazoking , again. Thanks for you effort on this :)

muuki88 added a commit that referenced this pull request Feb 25, 2015
@muuki88 muuki88 merged commit aa85388 into master Feb 25, 2015
@muuki88 muuki88 deleted the fix/windows-test-appveyor branch February 25, 2015 08:38
@muuki88
Copy link
Contributor Author

muuki88 commented Feb 25, 2015

Java 6 is fine, as we will drop the support in 1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants