FIX #405: Script replacements doesn't work with jdeb packaging #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| controlScripts foreach { case (file, script) => IO.copyFile(file, controlDir / script) } | ||
| for ((file, name) <- controlScripts) { | ||
| val targetFile = controlDir / name | ||
| copyAndFixPerms(file, targetFile, LinuxFileMetaData()) |
There was a problem hiding this comment.
We can use this as windows will not work as chmod is used.
You have to implement the subset of this function yourself ( in Java 7 we can remove
a lot of this clunky code )
|
I forgot about win( I'll try to fix a bit later. |
|
No problem :) you are super fast anyway |
|
Is it fine to override this functions and just remove chmod invocation? JDeb will fix perms on its side. |
|
Exactly. I wouldn't override, but create a new function. |
kardapoltsev
force-pushed
the
wip/jdeb-script-replacements
branch
from
087840f
to
9974c1f
Compare
|
Smooth. Let's wait for travis and then this should be good to go. |
|
It'll be nice since I've updated one of my projects build to 1.0.0 and native packaging is really slow :( |
muuki88
added a commit
that referenced
this pull request
Nov 11, 2014
FIX #405: Script replacements doesn't work with jdeb packaging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.