Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for classifiers in multiproject builds #333

Merged
merged 1 commit into from
Aug 29, 2014

Conversation

jroper
Copy link
Member

@jroper jroper commented Aug 25, 2014

If one project has two dependencies on another project for different classifiers in that project, this ensures that both dependencies are included.

@jroper
Copy link
Member Author

jroper commented Aug 25, 2014

jdk6 build failed because apparently jdk6 doesn't let you create an empty zip file. jdk8 build failed because it wasn't able to allocate resources. I'll fix the jdk6 build issue.

If one project has two dependencies on another project for different
classifiers in that project, this ensures that both dependencies are
included.
@jroper
Copy link
Member Author

jroper commented Aug 25, 2014

jdk6 build is fixed, jdk8 build has a resource problem, I don't think it has anything to do with this change.

@muuki88
Copy link
Contributor

muuki88 commented Aug 25, 2014

Hi James, thanks for this fix. The Travis ci build sometimes fail due to memory/timeout reasons.
The classifier attribute is nothing special regarding SBT 0.12/0.13 , right?

@sihil
Copy link

sihil commented Aug 29, 2014

This branch fixes a build problem I've encountered as well and would like to see it merged. 👍

muuki88 added a commit that referenced this pull request Aug 29, 2014
Added support for classifiers in multiproject builds
@muuki88 muuki88 merged commit 9ebb44b into sbt:master Aug 29, 2014
@muuki88
Copy link
Contributor

muuki88 commented Aug 31, 2014

merged into v0.7.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
universal Zip, tar.gz, tgz and bash issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants