Let bash-template work when the directory contains spaces. #267
Conversation
I think the important part is just the first two diffs. The rest may be unnecessary, but I think makes the behavior clearer.
| } | ||
| addApp () { | ||
| dlog "[addApp] arg = '$1'" | ||
| app_commands=( "${app_commands[@]}" "$1" ) | ||
| app_commands+=( "$1" ) |
There was a problem hiding this comment.
Do you know which version of BASH this is supported in?
There was a problem hiding this comment.
It could just be my ignorance :)
There was a problem hiding this comment.
Oh, good question. From the Bash changelog it looks to me like it might have been added in 3.1. Is that old enough? Maybe.
Sorry about these mostly unrelated changes. I was trying to figure out why the space in -Duser.dir= was causing problems, and I was hoping these would help, but they did not. (I'm not very good with Bash.) In the end the fix was c132333 — your change, that I did not have.
Let me know if you would prefer these += diffs reverted!
|
LGTM with one question. Let's see what travis says. |
|
LGTM, too. @jsuereth In a few weeks I will try to develope some docker images to build integration tests which run on travis ci and actually run all the bash scripts. |
Let bash-template work when the directory contains spaces.
I think the important part is just the first two diffs. The rest may be unnecessary, but I think makes the behavior clearer.
I'd recommend renaming
test-projecttotest projectto cover this issue.