Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing normalizedKey in packagerSettings. #188 #189

Merged
merged 1 commit into from
Mar 10, 2014
Merged

Conversation

muuki88
Copy link
Contributor

@muuki88 muuki88 commented Mar 10, 2014

To answer this TODO Do these keys belong here?: IMHO not.

@@ -9,9 +9,6 @@ object Keys extends linux.Keys
with windows.WindowsKeys
with universal.UniversalKeys {

// TODO - Do these keys belong here?
def normalizedName = sbt.Keys.normalizedName
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just an alias. I use this as a means of telling myself what keys I use elsewhere. It's ok to remove.

jsuereth added a commit that referenced this pull request Mar 10, 2014
Removing `normalizedKey` in packagerSettings. #188
@jsuereth jsuereth merged commit 3b92956 into master Mar 10, 2014
@jsuereth jsuereth deleted the wip/normalizedKey branch March 10, 2014 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants