Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support `--' to stop parsing options of sbt-native-packager itself. #184

Merged
merged 2 commits into from
Mar 6, 2014

Conversation

tksk
Copy link
Contributor

@tksk tksk commented Mar 5, 2014

When I want my command to take options conflict with sbt-native-packager's one. e.g. -d' $ mycommand -- -d will be eaten by mycommand`

@lightbend-cla-validator
Copy link

Hi @tksk,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Typesafe Contributors License Agreement:

http://typesafe.com/contribute/cla

@tksk
Copy link
Contributor Author

tksk commented Mar 5, 2014

I did sign the CLA.

@muuki88
Copy link
Contributor

muuki88 commented Mar 5, 2014

Thanks for the contribution. LGTM.

To clarify that I understand everything correctly. The -- separates the build-in commands from your special application commands if they collide with the build-in ones. So

# would just the $debug to 1 but not passed to the application
./start-script -d

with your fix

# enabling debug and sending -d as app argument
./start-script -d -- -d

Can you add an output to the usage command to clarify this?

@tksk
Copy link
Contributor Author

tksk commented Mar 6, 2014

PTAL.
IMHO, you understand everything correctly.

@muuki88
Copy link
Contributor

muuki88 commented Mar 6, 2014

Perfect :) Thanks a lot for your time

muuki88 added a commit that referenced this pull request Mar 6, 2014
Support `--' to stop parsing options of sbt-native-packager itself.
@muuki88 muuki88 merged commit 842aeee into sbt:master Mar 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants