Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Windows msi installer PATH entry #169

Merged
merged 1 commit into from
Feb 15, 2014
Merged

Fix Windows msi installer PATH entry #169

merged 1 commit into from
Feb 15, 2014

Conversation

rvs1257
Copy link
Contributor

@rvs1257 rvs1257 commented Feb 14, 2014

During sbt installation on Windows7 x64 with the msi, SBT_HOME (from [INSTALLDIR]), was set to C:\Program Files (x86)\sbt\, PATH was then updated with C:\Program Files (x86)\sbt\\bin so sbt could not be run from the command line due to the double back slash.

I could not run windows:package-msi to test my change, but using SuperOrca to change the msi PATH from [~];[INSTALLDIR]\bin to [~];[INSTALLDIR]bin and reinstalling sbt with the updated msi fixed the problem.

Running windows:package-msi with the latest source errored out with:
[error] Not a valid key: package-msi (similar: package-site, package-bin, package-src)

Fix Windows msi installer PATH entry
aea1a47 
During sbt installation on Windows7 x64 with the msi, SBT_HOME, [INSTALLDIR], was set to `C:\Program Files (x86)\sbt\`, PATH was then updated with `C:\Program Files (x86)\sbt\\bin` so sbt could not be run from the command line due to the double back slash.

I could not run windows:package-msi to test my change, but using SuperOrca to change the msi PATH from `[~];[INSTALLDIR]\bin` to `[~];[INSTALLDIR]bin` and reinstalling sbt with the updated msi fixed the problem.

Running `windows:package-msi` errored with:
`[error] Not a valid key: package-msi (similar: package-site, package-bin, package-src)`
@lightbend-cla-validator
Copy link

Hi @interestInCode,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Typesafe Contributors License Agreement:

http://typesafe.com/contribute/cla

@jsuereth
Copy link
Member

looks good! let me know once you've signe dthe CLA.

@rvs1257
Copy link
Contributor Author

rvs1257 commented Feb 15, 2014

Signed. I also learnt my error was in trying to run windows:package-msi in sbt-native-packager instead of sbt-launcher-package where sbt.msi is built.

muuki88 added a commit that referenced this pull request Feb 15, 2014
@muuki88
Merge pull request #169 from interestincode/patch-1
7fe518c 
Fix Windows msi installer PATH entry
@muuki88 muuki88 merged commit 7fe518c into sbt:master Feb 15, 2014
@jsuereth
Copy link
Member

Sweet, so do you need a release that sbt-launcher-package uses of the sbt.msi? We should have a 0.13.2-M2 shortly, which will contain within a launcehr compatable with 0.12.x->0.13.x. I'll make sure to delay releasing natives until this fix is all the way through.

@rvs1257
Copy link
Contributor Author

rvs1257 commented Feb 17, 2014

Hi @jsuereth, I didn't really need it for anything, I just wanted to see if I could do something about the bug.

@dwijnand dwijnand mentioned this pull request Aug 22, 2016
Merged
dwijnand added a commit to sbt/sbt-launcher-package that referenced this pull request Aug 22, 2016
@dwijnand
Upgrade to sbt-native-packager 1.1.1. Fixes #76.
cffb8e0 
The upgrade includes this fix sbt/sbt-native-packager#169
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rvs1257 @lightbend-cla-validator @jsuereth @muuki88