Fixes remote debug connections closing #1546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh boy 😄 Thanks for fixing this. Will this break JDK 8 users (surely no one is still running this 😜 ) |
muuki88
approved these changes
Jul 24, 2023
qwe2
added a commit
to qwe2/sbt-native-packager
that referenced
this pull request
Jan 22, 2025
This reverts commit 665e4e2.
muuki88
added a commit
that referenced
this pull request
Feb 4, 2025
* Add bash and ash tests for the -jvm-debug and -h flags * Add missing functions to the ash template * replace bash syntax with ash compatible one * Revert "Fixes remote debug connections closing (#1546)" This reverts commit 665e4e2. * fix sbt 2.0 cross-build for new tests --------- Co-authored-by: Muki Seiler <muuki88@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sbt-native-packager Java App archetype remote debugging is broken when using
-jvm-debug <port>in the docker entrypoint. It will start with-agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=<port>, which will terminate the connection prematurely.Adding the * before the port will allow all remote connections to connect to the debugger port, which was the old default behavior.
See https://bugs.openjdk.org/browse/JDK-8175050